Skip to content

add byonoy luminescence and absorbance plate readers #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

add byonoy luminescence and absorbance plate readers #617

wants to merge 24 commits into from

Conversation

@rickwierenga
Copy link
Member

@rickwierenga rickwierenga commented Jul 23, 2025 •
edited by BioCam
Loading

absorbance will follow soon

todo:

  • resource model
  • perform the check whether this machine does lum or abs (same firmware api)
  • status checks: read out orientation, temperature, humidity, device info, etc.
  • tests

@rickwierenga rickwierenga changed the title add byonoy luminescence plate reader add byonoy luminescence and absorbance plate readers Jul 27, 2025
@rickwierenga rickwierenga force-pushed the byonoy-luminescence branch from 1c31283 to 8f25dbf Compare July 27, 2025 23:55
@rickwierenga rickwierenga force-pushed the byonoy-luminescence branch from 300934e to 581d659 Compare July 28, 2025 04:37
@rickwierenga rickwierenga force-pushed the main branch 5 times, most recently from 49a6770 to 159fd78 Compare August 29, 2025 21:51
byonoy-dne
byonoy-dne reviewed Sep 16, 2025
View reviewed changes
@rickwierenga rickwierenga force-pushed the main branch 2 times, most recently from bffeb24 to a1d61b7 Compare September 23, 2025 01:22
@rickwierenga
Copy link
Member Author

rickwierenga commented Oct 1, 2025

@BioCam could you please test? I have verified both to work on our machines

@rickwierenga rickwierenga force-pushed the main branch 2 times, most recently from 1675cd6 to 2b2f7f9 Compare October 21, 2025 00:09
@BioCam
Copy link
Collaborator

BioCam commented Nov 28, 2025

Could you please confirm that this is the integration architecture?

Screenshot 2025-11-28 at 17 00 00
  1. What is the byonoy_absorbance_adapter? Is it the same as what the OEM's manual calls "SBS Adapter"?
  2. Is the term "base" here used to refer to two different things?:
    (i) _ByonoyBase the superclass to the machine backends - application=machine communication -, and
    (ii) ByonoyBase an aggregate Resource class that stores child_location for both the plate and the illumination_unit - application=resource modelling.
    This is very confusing, why don't we adapt the terminology from the OEM for everything physical?:
    2d32f4fafe7bfdc01af8564f9fcfd73ba8e78b37_2_590x499

BioCam
BioCam reviewed Nov 28, 2025
View reviewed changes
pylabrobot/plate_reading/byonoy/byonoy.py
size_y=85.59, # measured
size_z=14.07, # measured
child_location=Coordinate(
x=-(138 - 127.76) / 2, # measured
Copy link
Collaborator

@BioCam BioCam Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the 138 mm come from?

pylabrobot/plate_reading/byonoy/byonoy.py
size_x=127.76,
size_y=85.59,
size_z=0,
child_location=Coordinate(x=(138 - 127.76) / 2, y=(95.7 - 85.59) / 2, z=27.7),
Copy link
Collaborator

@BioCam BioCam Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 27.7 mm the distance from the bottom of the "SBS Adapter" to the surface that the plate sits on?

I am getting:

  • SBS_adapter.size_z = 17 mm
  • detection_unit.size_z = 20 mm
  • detection_unit.child_location.z = 16 mm

Copy link
Collaborator

@BioCam BioCam Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. I am getting the exact same dimensions for the dimensions which are specified in the manual:

Screenshot 2025-11-28 at 17 11 07

@BioCam
Copy link
Collaborator

BioCam commented Nov 30, 2025

Are measurements on this machine taken to 5 decimal places but the OEM's manual states the machine has a resolution to 3 decimal places?

@BioCam
Copy link
Collaborator

BioCam commented Dec 1, 2025

explaination to f9bca03

when going through the setup before, everything worked but when performing an absorbance measurement the firmware would speak to me: saying "Please initialise before measuring!", and fails to retrieve a measurement.

PLR firmware/io log:
Screenshot 2025-12-01 at 16 26 33

... what a fun - and incredibly direct firmware - love it!

I noticed this is not happening IF I have used the app first -> I traced the issue to the fact that the app performs a specific reference measurement first, the machine appears to remember that measurement until reboot.

I added a PLR version of this measurement and refactored the measurement command to enable reference and sample measurements separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BioCam BioCam BioCam left review comments

+1 more reviewer

@byonoy-dne byonoy-dne byonoy-dne left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickwierenga @BioCam @byonoy-dne